Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add condition on select #296

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SondreElg
Copy link
Contributor

@SondreElg SondreElg commented Aug 15, 2024

Functionality added to add condition to the condition view when clicking enter or selecting the condition from the dropdown,. Check for enter also added to conditionDiv to ensure the same behaviour holds true for custom/improvised conditions.

Pull Request Description

Proposed changes are made to streamline workflow by ensuring users won't have to leave the comfort of their keyboard between typing and adding a condition.

Changes Proposed

  • Add condition to condition view on enter click

Related Issues

Checklist

  • I have read the contribution guidelines and code of conduct.
  • I have tested the changes locally and they are working as expected.
  • I have added appropriate comments and documentation for the code changes.
  • My code follows the coding style and standards of this project.
  • I have rebased my branch on the latest main (or master) branch.
  • All tests (if applicable) have passed successfully.
  • I have checked for any potential security issues or vulnerabilities.

Additional Notes

I haven't run my linter as my and Javelent's settings are different and cause massive merge conflicts, but the changes should be styled properly.

Fixed conditionDiv such that condition is added to the condition view when clicking enter or selecting the condition from the dropdown.
Check for enter also added to conditionDiv to ensure the same behaviour holds true for custom/improvised conditions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant