feat: add custom window name setting (#35)

* add custom window name setting * fix: sync with new second window process --------- Co-authored-by: Jeremy Valentine <[email protected]>
javalent · Jan 3, 2024 · 01ca9bc · 01ca9bc
1 parent d1ec7f2
commit 01ca9bc
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 4 deletions.
diff --git a/src/@types/index.d.ts b/src/@types/index.d.ts
@@ -1,5 +1,7 @@
 export interface PluginSettings {
     saveWindowLocations: boolean;
+    useCustomWindowName: boolean;
+    customWindowName: string;
     /**
      * indexed by configured window name, plus the default window at "DEFAULT"
      */ 

diff --git a/src/main.ts b/src/main.ts
@@ -23,8 +23,12 @@ import { generateSlug } from "random-word-slugs";
 
 import * as os from "os";
 
+const DEFAULT_WINDOW_NAME = "Second Window";
+
 const DEFAULT_SETTINGS: PluginSettings = {
     saveWindowLocations: true,
+    useCustomWindowName: false,
+    customWindowName: DEFAULT_WINDOW_NAME,
     windows: {}
 };
 
@@ -160,12 +164,19 @@ class NamedWindow extends Component {
             );
         }
 
-        this.window.win.electronWindow.setTitle(file.name);
-
         await this.leaf.openFile(file, { state: { mode: "preview" } });
 
         this.window.rootEl.querySelector(".status-bar")?.detach();
         this.adjust(this.leaf, /image/.test(getType(file.extension)));
+        if (this.parent.settings.useCustomWindowName) {
+            this.window.win.electronWindow.setTitle(
+                this.name !== DEFAULT_WINDOW_NAME
+                    ? this.name
+                    : this.parent.settings.customWindowName
+            );
+        } else {
+            this.window.win.electronWindow.setTitle(file.name);
+        }
     }
     /**
      * Save window position and size under a key specific to the host.  This way,
@@ -200,8 +211,6 @@ class NamedWindow extends Component {
     }
 }
 
-const DEFAULT_WINDOW_NAME = "DEFAULT";
-
 class ImageWindowSettingTab extends PluginSettingTab {
     constructor(private plugin: Plugin, private parent: Parent) {
         super(parent.app, plugin);
@@ -237,6 +246,38 @@ class ImageWindowSettingTab extends PluginSettingTab {
                         await this.parent.saveSettings();
                     })
             );
+
+        new Setting(containerEl)
+            .setName("Use Custom Window Name")
+            .setDesc(
+                "If true, use a custom window name instead of the file name. Set as window's name when using named windows."
+            )
+            .addToggle((toggle) =>
+                toggle
+                    .setValue(this.parent.settings.useCustomWindowName)
+                    .onChange(async (value) => {
+                        this.parent.settings.useCustomWindowName = value;
+                        await this.parent.saveSettings();
+                        this.display();
+                    })
+            );
+
+        if (this.parent.settings.useCustomWindowName) {
+            new Setting(containerEl)
+                .setName("Custom Window Name")
+                .setDesc(
+                    "The custom window name to show when not using named windows."
+                )
+                .addText((text) =>
+                    text
+                        .setValue(this.parent.settings.customWindowName)
+                        .onChange(async (value) => {
+                            this.parent.settings.customWindowName = value;
+                            await this.parent.saveSettings();
+                        })
+                );
+        }
+
         this.buildWindows(this.containerEl.createDiv());
     }
     buildWindows(el: HTMLElement) {
@@ -331,6 +372,12 @@ export default class ImageWindow extends Plugin {
     }
     async onload() {
         await this.loadSettings();
+        if ("DEFAULT" in this.settings.windows) {
+            this.settings.windows[DEFAULT_WINDOW_NAME] = {
+                ...this.settings.windows.DEFAULT
+            };
+            delete this.settings.windows.DEFAULT;
+        }
         this.addSettingTab(new ImageWindowSettingTab(this, this));
 
         this.registerEvent(