Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error actor is none #613

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

morghim
Copy link

@morghim morghim commented Mar 2, 2024

No description provided.

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.22%. Comparing base (ac720cd) to head (48c4113).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #613   +/-   ##
=======================================
  Coverage   95.21%   95.22%           
=======================================
  Files          31       31           
  Lines        1025     1026    +1     
=======================================
+ Hits          976      977    +1     
  Misses         49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hramezani
Copy link
Member

@morghim

Could you please explain what problem are you going to solve?
Please share an example to show what is the problem

@morghim
Copy link
Author

morghim commented Mar 4, 2024

@morghim

Could you please explain what problem are you going to solve? Please share an example to show what is the problem

When I use library with rest framework any action user do save log with actor none , the library not catch user how make action

What I do is use another library crum to catch user using thread local and I added to single make log

@hramezani
Copy link
Member

Have you checked the problem in V3 Beta? As you may know, we are working on V3 major release. it is in Beta stage. You can install the V3 beta by pip install django-auditlog --pre. Please test the problem with the Beta first.

Preparing a small example case to reproduce the problem would be great. Please add a falling test.
Also, I don't want to add extra dependency to the library because of fixing this problem. please fix it with the existing functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants