Added Signals #362
Open
Added Signals #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jezdez, Any news ? |
jezdez
requested changes
Jan 8, 2022
There was a problem hiding this comment.
Sorry for the slow review @ZuluPro, this looks good in general and just needs some tweaks for the parameter names to account for what is being passed (a submission object) to the signal callback.
Also this would need to be documented to be merged :) Thank you!
| @@ -584,6 +585,7 @@ def submit(self): | |||
| assert self.publish_date < now(), \ | |||
| 'Something smells fishy; submission time in future.' | |||
|
|
|||
| signals.pre_submit.send(sender=self.__class__, message=self) | |||
There was a problem hiding this comment.
The parameter shouldn't be called message if the object passed isn't a message but the submission object.
Suggested change
| signals.pre_submit.send(sender=self.__class__, message=self) | |
| signals.pre_submit.send(sender=self.__class__, submission=self) |
| @@ -600,6 +602,7 @@ def submit(self): | |||
| finally: | |||
| self.sending = False | |||
| self.save() | |||
| signals.post_submit.send(sender=self.__class__, message=self) | |||
There was a problem hiding this comment.
Suggested change
| signals.post_submit.send(sender=self.__class__, message=self) | |
| signals.post_submit.send(sender=self.__class__, submission=self) |
| @@ -635,14 +638,14 @@ def send_message(self, subscription): | |||
| "text/html" | |||
| ) | |||
|
|
|||
| signals.pre_send.send(sender=self.__class__, message=self, email=message) | |||
There was a problem hiding this comment.
Suggested change
| signals.pre_send.send(sender=self.__class__, message=self, email=message) | |
| signals.pre_send.send(sender=self.__class__, submission=self, message=message) |
| @@ -651,6 +654,9 @@ def send_message(self, subscription): | |||
| {'subscription': subscription, | |||
| 'error': e} | |||
| ) | |||
| error = e | |||
| signals.post_send.send(sender=self.__class__, message=self, email=message, | |||
There was a problem hiding this comment.
Suggested change
| signals.post_send.send(sender=self.__class__, message=self, email=message, | |
| signals.post_send.send(sender=self.__class__, submission=self, message=message, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added signals for external usage: