Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using importlib instead of pkg_resources #391

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions newsletter/__init__.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,26 @@
from pkg_resources import get_distribution, DistributionNotFound
PACKAGE_NAME = "django-newsletter"

# importlib is available in python >= 3.8.
# Remove the except importError once support for python < 3.8 is dropped.

try:
__version__ = get_distribution("django-newsletter").version
except DistributionNotFound:
# package is not installed
__version__ = None
from importlib.metadata import distribution, PackageNotFoundError

def get_distribution_version():
try:
return distribution(PACKAGE_NAME).version
except PackageNotFoundError:
# package is not installed
return None
except ImportError:
from pkg_resources import get_distribution, DistributionNotFound

def get_distribution_version():
try:
return get_distribution(PACKAGE_NAME).version
except DistributionNotFound:
# package is not installed
return None


__version__ = get_distribution_version()
Loading