Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace isort with ruff #1459

Merged
merged 2 commits into from
Aug 15, 2024
Merged

replace isort with ruff #1459

merged 2 commits into from
Aug 15, 2024

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Aug 15, 2024 •
edited
Loading

Description of the Change

This PR replaces isort with ruff, already introduced in #1457 for format checking.

I enables isort and Q enables flake8-quotes rules.

[tool.ruff.lint]
select = ["I", "Q"]

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk n2ygk added this to the 3.0.0 milestone Aug 15, 2024
@dulmandakh
Copy link
Contributor Author

I'll try to replace flake8 with ruff once this merged

n2ygk
n2ygk approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements!

@n2ygk n2ygk merged commit 7f9085f into jazzband:master Aug 15, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dulmandakh @n2ygk