Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cli options definitions to piptools.scripts.options module #1952

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

atugushev
Copy link
Member

pip-compile and pip-sync both have common options, so this change reduces duplication and ensures the options are consistent.

pip-compile and pip-sync both have common options, so this change
reduces duplication and ensures the options are consistent.
@atugushev atugushev added refactor Refactoring code skip-changelog Avoid listing in changelog labels Aug 4, 2023
Copy link
Member

@theryanwalker theryanwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! At least the descriptions are now synced:

Before:

$ pip-compile --help | grep -A 1 -- --index-url
  -i, --index-url TEXT            Change index URL (defaults to
                                  https://pypi.org/simple)
                                  
$ pip-sync --help | grep  -- --index-url
  -i, --index-url TEXT      Change index URL (defaults to PyPI)

After:

$ pip-compile --help | grep -A 1 -- --index-url
  -i, --index-url TEXT            Change index URL (defaults to
                                  https://pypi.org/simple)

$ pip-sync --help | grep -A 1 -- --index-url
  -i, --index-url TEXT      Change index URL (defaults to
                            https://pypi.org/simple)

@atugushev atugushev enabled auto-merge (squash) August 8, 2023 23:53
@atugushev atugushev merged commit cd5061c into jazzband:main Aug 9, 2023
34 checks passed
@atugushev atugushev deleted the options-module branch August 9, 2023 00:07
@atugushev
Copy link
Member Author

Thanks @theryanwalker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring code skip-changelog Avoid listing in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants