Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: transpose support dataset with no headers #560

Merged
merged 2 commits into from
Sep 6, 2023
Merged

feat: transpose support dataset with no headers #560

merged 2 commits into from
Sep 6, 2023

Conversation

sgqy
Copy link
Contributor

@sgqy sgqy commented Sep 5, 2023

data.transpose() raises TypeError: 'NoneType' object is not subscriptable, when headers is not set.

Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Almost ready, just a small typo.

def _transpose_without_headers(self):
"""Transpose a :class:`Dataset`, turning rows into columns and vice
versa, returning a new ``Dataset`` instance. This instance should not
has headers, or the dimension would be invalid."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has -> have

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #560 (fe7d8dd) into master (98b8c53) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
+ Coverage   91.64%   91.74%   +0.10%     
==========================================
  Files          28       28              
  Lines        2800     2823      +23     
==========================================
+ Hits         2566     2590      +24     
+ Misses        234      233       -1     
Files Changed Coverage Δ
src/tablib/core.py 85.71% <100.00%> (+0.56%) ⬆️
tests/test_tablib.py 98.79% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@claudep claudep merged commit 5431834 into jazzband:master Sep 6, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants