Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop/issue 863 #864

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

SteveGilham
Copy link
Contributor

@SteveGilham SteveGilham commented Jun 24, 2022

This is a change towards addressing the platform dependent behaviour of the Cecil binaries when resolving system assemblies.

This change extracts the net core and framework system assembly search strategies into protected methods that will be available in all builds -- avoiding the need to reimplement both in a platform neutral subclass; and provides a hook for examining the result before or after any resolution handler invocation, and making any other adjustments before an exception is thrown.

Additionally, in order to allow a custom resolver to instantiate per-assembly in the manner of DefaultAssemblyResolver when instantiated as a fallback, a layer of IAssemblyResolverProvider types and properties has been added.

There are no changes to the existing platform dependent behaviour at this point -- the NET_CORE build doesn't look in the GAC, and the !NET_CORE one doesn't look in the dotnet shared locations, for example. Nor are any new resolver types or resolver provider types involved in the process without a caller opting in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant