Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose IDisposables in NativePdbWriter #952

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

omajid
Copy link

@omajid omajid commented Jun 20, 2024

  • The code creates a local variable that's an IDisposable (CustomMetadataWriter), but doesn't call Dispose() on it.

  • The CustomMetadataWriter class holds two IDisposables (MemoryStream and BinaryStreamWriter), but was only Dispose()ing one of them.

- The code creates a local variable that's an IDisposable
  (CustomMetadataWriter), but doesn't call Dispose() on it.

- The CustomMetadataWriter class holds two IDisposables (MemoryStream
  and BinaryStreamWriter), but was only Dispose()ing one of them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant