Fixed edge case in activation cache shuffling #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
tom-pollak
pushed a commit
to tom-pollak/SAELens
that referenced
this pull request
Oct 22, 2024
…dge-case Fixed edge case in activation cache shuffling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug where you could pass
buffer_idx_range=(0, 1)intoshuffle_activations_pairwise, it wouldn't raise an exception like it was supposed to and then get stuck in an infinite loop trying to find two non-identical indices within that range.This was particularly likely to happen during the final shuffling when caching activations, so I've added an if statement there to make sure final pairwise shuffling doesn't happen if there's only 1 cache file.