Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable full flake8 default rules list #16

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

chanind
Copy link
Collaborator

@chanind chanind commented Feb 27, 2024

This PR enables the full set of flake8 default rules by using extend-select and extend-ignore instead of select and ignore.

In addition, this PR makes the following notable changes:

  • Simplifies the Github action to just run flake8 . so it will use the same settings as the flake8 on local
  • Ignores the geom_median dir, since that's its own project, and its unclear if that should be linted by this
  • ignores E402 in dashboard_runner.py and generate_dashboards.py due to those files having sys.path.append() calls above imports. It's not clear to me why those calls are there, so I just left a TODO and ignored the error
  • removes # noqa statements that didn't seem necessary
  • adds r to regex strings, which I think was probably the intention anyway

closes #14

@jbloomAus jbloomAus merged commit ad84706 into jbloomAus:main Feb 28, 2024
2 checks passed
@jbloomAus
Copy link
Owner

@chanind Thanks so much!

tom-pollak pushed a commit to tom-pollak/SAELens that referenced this pull request Oct 22, 2024
chore: enable full flake8 default rules list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use flake8 extend-select instead of select
2 participants