SAE Group for sweeps PR #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chanind I'm having trouble reproducing the isort check fail locally which is somewhat frustrating. Don't suppose you could take a look and fix it? Would prefer to turn off the isort check if this delays us merging this for more than a day. |
|
weird, I'm able to reproduce these errors locally. The commands I'm running are: To display the error (same as what CI is running): To fix the errors: What are these commands outputting when you run them? Let me see if I can figure out how to make a PR to this fork's PR... |
|
I opened up a PR to @Benw8888's branch after running isort here: Benw8888#1. Merging this PR should fix the isort issue. I'm still confused why running |
chore: running isort to fix imports
tom-pollak
pushed a commit
to tom-pollak/SAELens
that referenced
this pull request
Oct 22, 2024
SAE Group for sweeps PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the SAEGroup class, which is basically a list of autoencoders, and which automatically initializes autoencoders based on which parameters of the config are passed as lists. Then I modified the training code to handle using SAEGroups.