Supply device to SAEConfigLoadOptions
#347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Thanks for finding this! just merged as this is a live bug. If you can add a test that would prevent this regression in the future that would be great as well |
|
Yep will add a test on my todo list for this week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug which was introduced last week. The issue seems to be that the
SAEConfigLoadOptionsclass was introduced which contains thedevicefield (defaultNone), and this field wasn't set when device is not None. Before this change, the config was just loaded directly from HuggingFace without overriding itsdevicevalue (which on HuggingFace presumably is "cuda").Would be great if this PR could be merged soon if possible, and I can try to add tests for this kind of failure mode afterwards.