Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-enabling isort in CI #86

Merged
merged 2 commits into from
Apr 18, 2024
Merged

chore: re-enabling isort in CI #86

merged 2 commits into from
Apr 18, 2024

Conversation

chanind
Copy link
Collaborator

@chanind chanind commented Apr 16, 2024

This PR re-enables isort in CI. If this is still an issue in the future, we should just remove isort entirely.

@chanind chanind force-pushed the re-enable-isort branch 2 times, most recently from b55c821 to 032322a Compare April 16, 2024 20:24
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.03%. Comparing base (1fc652c) to head (e155625).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   57.03%   57.03%           
=======================================
  Files          16       16           
  Lines        1394     1394           
  Branches      227      227           
=======================================
  Hits          795      795           
  Misses        558      558           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chanind
Copy link
Collaborator Author

chanind commented Apr 16, 2024

https://stackoverflow.com/questions/73471822/isort-sorting-things-differently-when-running-locally-than-in-ci-other-machines this question makes me think the inconsistencies with isort might have stemmed from the wandb folder locally making isort think wandb is a local module, and sorting it incorrectly. I added src_paths to the isort config, which should hopefully fix this issue

@chanind chanind merged commit 9c44731 into main Apr 18, 2024
6 checks passed
@chanind chanind deleted the re-enable-isort branch April 18, 2024 18:08
tom-pollak pushed a commit to tom-pollak/SAELens that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant