Skip to content

Commit

Permalink
fix 'change file add' URL on forks (#355)
Browse files Browse the repository at this point in the history
* fix 'change file add' URL on forks

* URL doesn't need ../..
  • Loading branch information
jbolda authored Jul 24, 2024
1 parent 294a3c0 commit 9f85eae
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .changes/action-supports-dry-run.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"action": patch:bug
"action": patch:enhance
---

The action now supports running in dry run mode. This enables testing of workflows and publish sequences prior to publishing.
5 changes: 5 additions & 0 deletions .changes/change-file-add-url-on-forks.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"action": patch:bug
---

The URL to create a change file on forks was broken. It was incorrectly pointing at the root repo.
4 changes: 2 additions & 2 deletions .changes/change-pr-350.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
"covector": patch
"action": patch
"covector": patch:bug
"action": patch:bug
---

Fix GitHub pull request comment link to correctly point at the docs.
2 changes: 1 addition & 1 deletion packages/action/src/comment/formatGithubComment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export function formatComment({
changeFolder: string;
}) {
let comment = `### Package Changes Through ${payload.pull_request.head.sha}\n`;
let addChangeFileUrl = `${payload.pull_request.html_url}/../../new/${
let addChangeFileUrl = `${payload.pull_request.head.repo.html_url}/new/${
payload.pull_request.head.ref
}${newChangeFile({
prNumber: payload.pull_request.number,
Expand Down

0 comments on commit 9f85eae

Please sign in to comment.