Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SET-742 Zeus: don't import specific service certificates into truststore #245

Merged
merged 1 commit into from
Apr 10, 2024
Merged

SET-742 Zeus: don't import specific service certificates into truststore #245

merged 1 commit into from
Apr 10, 2024

Conversation

RanabirChakraborty
Copy link
Contributor

@RanabirChakraborty RanabirChakraborty commented Apr 3, 2024 •
edited
Loading

@RanabirChakraborty
Copy link
Contributor Author

@spyrkob Can you please review it.

@rpelisse
Copy link
Collaborator

rpelisse commented Apr 3, 2024

Rather than remove the import/remove tasks, I would remove the root_ca one and simply change the list to ONLY contain root_ca.

@RanabirChakraborty
Copy link
Contributor Author

@rpelisse @spyrkob Can you please review this PR

rpelisse
rpelisse approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@rpelisse rpelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rpelisse rpelisse merged commit cb42b75 into jboss-set:main Apr 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpelisse rpelisse rpelisse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RanabirChakraborty @rpelisse