fix: ignore non-enumerable properties

jc-verse · May 19, 2022 · d3c513b · d3c513b
1 parent d681abd
commit d3c513b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ts-klass",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "Type-strong klasses",
   "main": "src/index.js",
   "types": "src/index.d.ts",

diff --git a/src/index.js b/src/index.js
@@ -15,6 +15,7 @@ function splitBody(body) {
     instanceMethods = [];
   Object.entries(Object.getOwnPropertyDescriptors(body)).forEach(
     ([key, value]) => {
+      if (!value.enumerable) return;
       if (key.startsWith("static "))
         staticFields.push([key.replace(/^static /, ""), value]);
       // TODO: `{ foo() {} }` and `{ foo: function () {} }` should be

diff --git a/test/index.test.js b/test/index.test.js
@@ -75,6 +75,13 @@ describe("klass constructor", () => {
     expect(cat.name).toBe("Fiona");
   });
 
+  it("ignores non-enumerable properties", () => {
+    const body = {};
+    Object.defineProperty(body, "hidden", { value: 1 });
+    const Animal = klass(body);
+    expect(Animal().hidden).toBe(undefined);
+  });
+
   describe("accepts getters & setters", () => {
     test("klass", () => {
       const Animal = klass({