feat: add Lettuce Redis watcher #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ShingmoYeung
commented
Sep 21, 2023
ShingmoYeung
commented
- Add Lettuce Redis watcher: retain the Redis Watcher based on Jedis implementation and as an optional, default Lettuce Redis Watcher, adapt to the subsequent SpringBoot.
- Update dependencies version: update dependent versions: e.g. jCasin, jdbc-adapter, etc.
- Update `org.casbin:jcasbin` from version 1.30.1 to 1.35.0 - Update `org.casbin:jcasbin-redis-watcher` from version 1.4.1 to 1.4.2 - Update `org.casbin:jdbc-adapter` from version 2.3.3 to 2.4.1 - Update `mysql:mysql-connector-java` from version 8.0.30 to 8.0.33 Add new configuration properties for Lettuce Redis Type in `CasbinProperties.java`: - Add `watcherLettuceRedisType` property with the default value of NONE Update getter and setter methods for `watcherLettuceRedisType` in `CasbinProperties.java` Add new class `CasbinWatcherLettuceRedisType.java` Update `CasbinRedisWatcherAutoConfiguration.java`: - Add import statement for `org.casbin.watcher.lettuce.LettuceRedisWatcher` - Add new conditional bean configuration for Lettuce Redis Watcher
The LettuceRedisWatcher class is imported, and a conditional statement is added to check the watcher type. If the type is "standalone", a new LettuceRedisWatcher instance is created and set as the watcher. If the type is "cluster", a new LettuceRedisWatcher instance is created with the cluster nodes and set as the watcher. If the watcher type is unsupported, a CasbinWatcherLettuceTypeUnsupportedException is thrown.
…n in CasbinRedisWatcherAutoConfiguration.java.
|
@tangyang9464 @imp2002 please review |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.