Only throw an error on a missing requestId on 200 level responses

see #38
jcberquist · Jan 27, 2022 · f77f707 · f77f707
1 parent a2a702b
commit f77f707
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/stripe.cfc b/stripe.cfc
@@ -111,7 +111,7 @@ component {
 
         if ( structKeyExists( response.headers, 'Request-Id' ) ) {
             response[ 'requestId' ] = response.headers[ 'Request-Id' ];
-        } else {
+        } else if ( int( response.status ) >= 200 && int( response.status ) < 300 ) {
             throw(
                 type = 'StripeResponseException',
                 message = 'Request-Id is missing from the response headers',

diff --git a/tests/specs/apiCallResponseSpec.cfc b/tests/specs/apiCallResponseSpec.cfc
@@ -23,7 +23,7 @@ component extends=testbox.system.BaseSpec {
                 httpService.$reset();
             } );
 
-            it( 'throws an error when the Request-Id header is missing', function() {
+            it( 'throws an error when the Request-Id header is missing on a 200 request', function() {
                 httpService.$(
                     'exec',
                     {
@@ -42,6 +42,26 @@ component extends=testbox.system.BaseSpec {
                     regex = 'Request-Id is missing from the response headers'
                 );
             } );
+
+            it( 'does not throw an error when the Request-Id header is missing on a non 200 request', function() {
+                httpService.$(
+                    'exec',
+                    {
+                        responseHeader: {
+                            'Content-Type': 'application/json'
+                        },
+                        statuscode: '401 Not Authorized',
+                        filecontent: '{}'
+                    }
+                );
+
+                expect( function() {
+                    res = stripe.accounts.retrieve();
+                } ).notToThrow(
+                    type = 'StripeResponseException',
+                    regex = 'Request-Id is missing from the response headers'
+                );
+            } );
         } );
     }