-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix creation functions with builtin like
kwarg
#23
Conversation
Hello @dwierichs! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-05-13 19:11:15 UTC |
Hi @dwierichs, thanks for the issue and quick PR! The test failure is genuine - and comes from the fact that the You could change the type check to something softer, with e.g.: assert "int" in ar.get_dtype_name(y) for the integer case. |
Thanks for the context @jcmgray , that would have taken me way too much time to find out 😅 I went for assert y.dtype in expected and a list of |
Perfect thanks very much! |
**Context:** Until a new version of autoray that uses PR jcmgray/autoray#23, we will pin to less that 0.6.10 to allow CI/CD to pass.
This PR fixes #22 by making
_maybe_inject_dtype_device
fall back to thetype
of the providedlike
input if the attributelike.dtype
does not exist.Tests are added accordingly.