Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ukrainian localization #83

Merged
merged 4 commits into from
May 5, 2024
Merged

Add Ukrainian localization #83

merged 4 commits into from
May 5, 2024

Conversation

balaraz
Copy link
Contributor

@balaraz balaraz commented May 5, 2024

I have added a translation for the Ukrainian language.

  • Application UI
  • Main metadata for stores

@balaraz
Copy link
Contributor Author

balaraz commented May 5, 2024

I didn't make any changes that could cause errors.

@jd1378
Copy link
Owner

jd1378 commented May 5, 2024

Hi
thanks for contributing

please remove translatable="false" entries from the translated file
if you use any quotes, make sure they are escaped using \ as well

  Removed all lines from the values-uk/strings.xml file
  that contain the 'translatable' attribute with a value of 'false'.
@balaraz
Copy link
Contributor Author

balaraz commented May 5, 2024

Hi thanks for contributing

please remove translatable="false" entries from the translated file if you use any quotes, make sure they are escaped using \ as well

I fixed both problems. Is everything okay now?

@jd1378 jd1378 merged commit cd32c70 into jd1378:main May 5, 2024
1 check passed
@jd1378
Copy link
Owner

jd1378 commented May 5, 2024

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants