Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return actual canvas coordinates whenever an item is added. #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cryptoquick
Copy link
Contributor

Isomer.add presently returns nothing, so I figured that was an excellent opportunity to return the canvas point data that's usually lost.

This is super important for making click detection work in https://github.com/cryptoquick/cubes and I'd imagine other people might find it handy too.

if (Object.prototype.toString.call(item) == '[object Array]') {
for (var i = 0; i < item.length; i++) {
this.add(item[i], baseColor);
canvasPaths.concat(this.add(item[i], baseColor));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized, I used concat incorrectly here. Concat returns a new array... This should be re-assigned. I'll get to that later tonight. 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant