Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(picker): support custom column field names #2460

Merged
merged 6 commits into from
Aug 17, 2023

Conversation

subordon
Copy link
Contributor

这个 PR 做了什么? (简要描述所做更改)

这个 PR 是什么类型? (至少选择一个)

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

这个 PR 涉及以下平台:

  • NutUI 4.0 H5
  • NutUI 4.0 小程序
  • NutUI 3.0 H5
  • NutUI 3.0 小程序

这个 PR 是否已自测:

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #2460 (ff50d4c) into v4 (a3965f2) will increase coverage by 0.00%.
Report is 3 commits behind head on v4.
The diff coverage is 72.72%.

@@           Coverage Diff           @@
##               v4    #2460   +/-   ##
=======================================
  Coverage   85.01%   85.01%           
=======================================
  Files         152      152           
  Lines       20416    20455   +39     
  Branches     2288     2290    +2     
=======================================
+ Hits        17356    17390   +34     
- Misses       3055     3060    +5     
  Partials        5        5           
Files Changed Coverage Δ
src/packages/__VUE/picker/usePicker.ts 74.87% <63.04%> (+1.13%) ⬆️
src/packages/__VUE/picker/Column.vue 74.61% <90.90%> (+0.31%) ⬆️
src/packages/__VUE/picker/baseProps.ts 100.00% <100.00%> (ø)
src/packages/__VUE/picker/index.vue 100.00% <100.00%> (ø)

@eiinu eiinu added this to the v4.1.3 milestone Jul 28, 2023
src/packages/__VUE/picker/baseProps.ts Outdated Show resolved Hide resolved
src/packages/__VUE/picker/types.ts Outdated Show resolved Hide resolved
src/packages/__VUE/picker/usePicker.ts Outdated Show resolved Hide resolved
@eiinu eiinu modified the milestones: v4.1.3, v4.1.4 Aug 3, 2023
@eiinu eiinu merged commit 977a805 into jdf2e:v4 Aug 17, 2023
4 of 5 checks passed
@subordon subordon deleted the feature_picker branch August 29, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants