Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): 修复组件item设置disabled时,还能滑动到过去的问题(#2486) #2559

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

yi-boide
Copy link
Contributor

这个 PR 做了什么? (简要描述所做更改)
修复tabs的子组件item设置disabled时,还能滑动到过去的问题(#2486)

这个 PR 是什么类型? (至少选择一个)

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

这个 PR 涉及以下平台:

  • NutUI 4.0 H5
  • NutUI 4.0 小程序
  • NutUI 3.0 H5
  • NutUI 3.0 小程序

这个 PR 是否已自测:

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08% ⚠️

Comparison is base (e9ec2b7) 84.99% compared to head (43a04dc) 84.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v4    #2559      +/-   ##
==========================================
- Coverage   84.99%   84.92%   -0.08%     
==========================================
  Files         150      150              
  Lines       20550    20568      +18     
  Branches     2303     2303              
==========================================
  Hits        17467    17467              
- Misses       3078     3096      +18     
  Partials        5        5              
Files Changed Coverage Δ
src/packages/__VUE/tabs/index.vue 80.51% <0.00%> (-3.90%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eiinu eiinu added this to the v4.1.7 milestone Sep 26, 2023
@eiinu eiinu merged commit ec8504f into jdf2e:v4 Oct 9, 2023
3 of 5 checks passed
@ljnMeow
Copy link

ljnMeow commented Oct 10, 2023

请问该bug修复后是否发布,为何我在官网尝试还是可以复现这个bug

@eiinu
Copy link
Member

eiinu commented Oct 10, 2023

请问该bug修复后是否发布,为何我在官网尝试还是可以复现这个bug

只是合并入主分支,还没发布 v4.1.7

@yi-boide yi-boide deleted the tabs-disabled branch November 7, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs组件,当组件item disabled设置为true时,通过手势滑动还是能滑动过去
3 participants