Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复上传组件安卓环境下无法唤起摄像头问题 #2567

Merged
merged 4 commits into from
Sep 18, 2023
Merged

fix: 修复上传组件安卓环境下无法唤起摄像头问题 #2567

merged 4 commits into from
Sep 18, 2023

Conversation

developeryvan
Copy link
Contributor

@developeryvan developeryvan commented Sep 16, 2023

这个 PR 做了什么? (简要描述所做更改)

修复上传组件安卓环境下无法唤起摄像头问题

这个 PR 是什么类型? (至少选择一个)

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

这个 PR 涉及以下平台:

  • NutUI 4.0 H5
  • NutUI 4.0 小程序
  • NutUI 3.0 H5
  • NutUI 3.0 小程序

这个 PR 是否已自测:

if (props.capture) params.capture = 'camera';
if (props.capture) {
params.capture = 'camera';
params.accept = 'image/*';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

即使对 accept 增加了默认值,也应该保证 props.accept 的最高优先级。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

即使对 accept 增加了默认值,也应该保证 props.accept 的最高优先级。

但是 我测试过 填写的值不是这个也没办法唤起摄像头

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.01% ⚠️

Comparison is base (e9ec2b7) 84.99% compared to head (132e1c5) 84.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v4    #2567      +/-   ##
==========================================
- Coverage   84.99%   84.99%   -0.01%     
==========================================
  Files         150      150              
  Lines       20550    20555       +5     
  Branches     2303     2301       -2     
==========================================
+ Hits        17467    17470       +3     
- Misses       3078     3080       +2     
  Partials        5        5              
Files Changed Coverage Δ
src/packages/__VUE/uploader/index.vue 60.66% <66.66%> (-0.01%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eiinu eiinu merged commit a6b5342 into jdf2e:v4 Sep 18, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants