Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(range, taro): 优化滑动事件处理逻辑 #2712

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Conversation

eiinu
Copy link
Member

@eiinu eiinu commented Dec 6, 2023

这个 PR 做了什么? (简要描述所做更改)

获取用于计算的 range 尺寸信息

  • 修改前:在每次 touch-move 时调用,异步操作,有可能会在 touch-end 回调之后执行,导致 change 事件无法触发
  • 修改后:仅在 onReady 时获取一次尺寸信息,touch-move/end 回调内均为同步操作

这个 PR 是什么类型? (至少选择一个)

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

这个 PR 涉及以下平台:

  • NutUI 4.0 H5
  • NutUI 4.0 小程序
  • NutUI 3.0 H5
  • NutUI 3.0 小程序

这个 PR 是否已自测:

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5cbc030) 85.11% compared to head (b7093ab) 85.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v4    #2712      +/-   ##
==========================================
- Coverage   85.11%   85.11%   -0.01%     
==========================================
  Files         167      167              
  Lines       21168    21166       -2     
  Branches     2379     2382       +3     
==========================================
- Hits        18018    18016       -2     
  Misses       3145     3145              
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eiinu eiinu changed the title fix(range): 优化滑动事件处理逻辑 fix(range, taro): 优化滑动事件处理逻辑 Dec 6, 2023
@eiinu eiinu merged commit 658fd09 into jdf2e:v4 Dec 6, 2023
5 checks passed
@eiinu eiinu deleted the fix-range branch December 6, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant