-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(button): script setup #2713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiinu
force-pushed
the
feat-setup-button
branch
from
December 7, 2023 12:07
9ad5385
to
3f958fb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v4 #2713 +/- ##
==========================================
- Coverage 84.98% 84.98% -0.01%
==========================================
Files 166 168 +2
Lines 21238 21263 +25
Branches 2420 2420
==========================================
+ Hits 18049 18070 +21
- Misses 3172 3176 +4
Partials 17 17 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
1、入口文件变更:
index.vue
->index.ts
index.taro.vue
->index.taro.ts
2、文件名称变更
index.vue
->button.vue
index.taro.vue
->button.taro.vue
3、入口文件中新增 Props 类型、Instance 类型导出
4、组件风格变更:script -> script setup
5、为了实现以上逻辑的构建代码变更
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台:
这个 PR 是否已自测: