Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(button): script setup #2713

Merged
merged 20 commits into from
Jan 15, 2024
Merged

refactor(button): script setup #2713

merged 20 commits into from
Jan 15, 2024

Conversation

eiinu
Copy link
Member

@eiinu eiinu commented Dec 7, 2023

这个 PR 做了什么? (简要描述所做更改)

1、入口文件变更:

  • index.vue -> index.ts
  • index.taro.vue -> index.taro.ts

2、文件名称变更

  • index.vue -> button.vue
  • index.taro.vue -> button.taro.vue

3、入口文件中新增 Props 类型、Instance 类型导出
4、组件风格变更:script -> script setup
5、为了实现以上逻辑的构建代码变更

这个 PR 是什么类型? (至少选择一个)

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

这个 PR 涉及以下平台:

  • NutUI 4.0 H5
  • NutUI 4.0 小程序
  • NutUI 3.0 H5
  • NutUI 3.0 小程序

这个 PR 是否已自测:

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (53f31ab) 84.98% compared to head (6b629c0) 84.98%.

❗ Current head 6b629c0 differs from pull request most recent head 612a7b2. Consider uploading reports for the commit 612a7b2 to get more accurate results

Files Patch % Lines
src/packages/__VUE/button/button.vue 88.77% 11 Missing ⚠️
src/packages/utils/with-install.ts 75.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v4    #2713      +/-   ##
==========================================
- Coverage   84.98%   84.98%   -0.01%     
==========================================
  Files         166      168       +2     
  Lines       21238    21263      +25     
  Branches     2420     2420              
==========================================
+ Hits        18049    18070      +21     
- Misses       3172     3176       +4     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eiinu eiinu marked this pull request as draft December 14, 2023 08:25
@eiinu eiinu marked this pull request as ready for review January 15, 2024 15:46
@eiinu eiinu merged commit c764c28 into jdf2e:v4 Jan 15, 2024
4 checks passed
@eiinu eiinu deleted the feat-setup-button branch January 15, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant