Feature/allow separate and parameters & Fix Relation with Or #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. First, we must remove all filtered query parameter 2. Check each query parameter for the special flage `.*__and` or `.*__or` 3. If that exists group in the `where` or `orWhere` clause respectively This seems to actually work.
(Fix unused variable) 1. First, we must remove all filtered query parameter 2. Check each query parameter for the special flage `.*__and` or `.*__or` 3. If that exists group in the `where` or `orWhere` clause respectively This seems to actually work.
(Always group them!) 1. First, we must remove all filtered query parameter 2. Check each query parameter for the special flage `.*__and` or `.*__or` 3. If that exists group in the `where` or `orWhere` clause respectively This seems to actually work.
|
Hmmmm...I'll look at the test that failed. Anyone know, though, why the external coverage from external is not available, or no code coverage driver is available? Is that because of the failed unit test? |
|
Bah! I'll need to fiddle all the tests because I just realised that this change causes all the queries to look like they're nested and so a bunch of assertions are wrong. So my diagnosis is:
I say this on the basis I have this in production, as such :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no tests for this (but it does work) and this PR is more for discussion.
This address issue #42 by allowing users to append
__andand__or; all the__andwill group together and the__ors are self explanatory. So you can do:It also fixes #38 which is a duplicate of PR #39 but I'm not sure #39 works.