Patch to fix Home Assistant Blocking Call warnings #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch for jekalmin#217
jleinenbach
changed the title
jekalmin
requested changes
Oct 27, 2024
There was a problem hiding this comment.
Thanks for your contribution!
Could you make a change as commented?
I referenced the code from below.
https://developers.home-assistant.io/docs/asyncio_blocking_operations/#running-blocking-calls-in-the-executor
Comment on lines
+167
to
+173
| # Define an asynchronous function that lists models with a timeout using asyncio.to_thread | ||
| async def list_models_with_timeout(): | ||
| # Use asyncio.to_thread to run the blocking call in a separate thread | ||
| return await asyncio.to_thread(client.models.list, timeout=10) | ||
|
|
||
| # Await the execution of the list_models_with_timeout function | ||
| await list_models_with_timeout() |
There was a problem hiding this comment.
Could you change this to following?
Suggested change
| # Define an asynchronous function that lists models with a timeout using asyncio.to_thread | |
| async def list_models_with_timeout(): | |
| # Use asyncio.to_thread to run the blocking call in a separate thread | |
| return await asyncio.to_thread(client.models.list, timeout=10) | |
| # Await the execution of the list_models_with_timeout function | |
| await list_models_with_timeout() | |
| await hass.async_add_executor_job(partial(client.models.list, timeout=10)) |
Also, importing partial is required at the top.
from functools import partial
|
Let me fix changes as I suggested above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve:
#217