Remove AccountManager support #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
app/src/main/java/org/jellyfin/androidtv/auth/AccountManagerMigration.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/org/jellyfin/androidtv/auth/AccountManagerMigration.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/org/jellyfin/androidtv/auth/AccountManagerMigration.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/org/jellyfin/androidtv/auth/AccountManagerMigration.kt
Fixed
Show fixed
Hide fixed
nielsvanvelzen
force-pushed
the
drop-account-manager
branch
2 times, most recently
from
3c11363
to
9b89a0f
Compare
nielsvanvelzen
force-pushed
the
drop-account-manager
branch
from
9b89a0f
to
369bdc8
Compare
nielsvanvelzen
force-pushed
the
drop-account-manager
branch
from
369bdc8
to
7d7e6fa
Compare
crobibero
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my personal roadmap:
The migration will not work on all Android devices (at least everything below Lolipop, API 22, will not work). In this case the user needs to sign in manually again. It should work on pretty much all other devices (tested on Fire TV/Shield).
Changes
The migration is in a second commit which can be reverted after 0.16 is released to clean up the manifest entries etc.
Issues
Fixes #2503