Add "ask to skip" media segment action #4068
Merged
+213
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -86,7 +86,7 @@ | |||
| import timber.log.Timber; | |||
|
|
|||
| public class CustomPlaybackOverlayFragment extends Fragment implements LiveTvGuide, View.OnKeyListener { | |||
| private VlcPlayerInterfaceBinding binding; | |||
| protected VlcPlayerInterfaceBinding binding; | |||
Check notice
Code scanning / Android Lint
Unknown nullness Note
| @@ -84,6 +94,8 @@ | |||
| val action = getDefaultSegmentTypeAction(segment.type) | |||
| // Skip the skip action if timespan is too short | |||
| if (action == MediaSegmentAction.SKIP && segment.duration < MediaSegmentRepository.SkipMinDuration) return MediaSegmentAction.NOTHING | |||
| // Skip the ask to skip action if timespan is too short | |||
| if (action == MediaSegmentAction.ASK_TO_SKIP && segment.duration < MediaSegmentRepository.AskToSkipMinDuration) return MediaSegmentAction.NOTHING | |||
Check warning
Code scanning / detekt
Line detected, which is longer than the defined maximum line length in the code style. Warning
crobibero
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition to #4052. This one adds a new action "ask to skip". When enabled for a segment type, this action will show a message on-screen to suggest skipping the segment. This only shows when the segment is at least 3 seconds long and the message disappears 1 second before the segment ends or 8 seconds after it is shown. Opening/closing the playback overlay also resets that timer as the skipping functionality is not working when any other UI is open.
The implementation is a bit of a hack as the player UI is partially leanback, partially custom and now partially compose. When we rewrite the player UI with compose we can make it a bit more integrated with less hacks.
Changes
Screenshots
Issues