-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove dependency on @uupaa/dynamic-import-polyfill
#6137
base: master
Are you sure you want to change the base?
Conversation
The |
Please, change your base branch to master, I think no more PR will be merged to 10.9 since it's freeze now |
Removed the dependency on `@uupaa/dynamic-import-polyfill` and switched to using raw `import()`, because the polyfill were having issues with `async`/`await` in plugin modules which were using `await` at the top-level in the module to e.g. do dynamic imports because plugins don't have a base-point to do static imports of other modules.
ee2972a
to
89613fc
Compare
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
Moved to |
Quality Gate passedIssues Measures |
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
Changes
Removed the dependency on
@uupaa/dynamic-import-polyfill
and switched to using rawimport()
, because the polyfill were having issues withasync
/await
in plugin modules which were usingawait
at the top-level in the module to e.g. do dynamic imports because plugins don't have a base-point to do static imports of other modules.Issues