Skip to content

Commit

Permalink
Use newer spotbugs plugin (#107)
Browse files Browse the repository at this point in the history
Suppresses the new spotbugs warnings because Jenkins plugins are
generally not at risk for finalizer attacks.
  • Loading branch information
MarkEWaite authored Dec 20, 2023
1 parent 1e0f65b commit eb5b402
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
3 changes: 3 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@
<gitHubRepo>jenkinsci/cloud-stats-plugin</gitHubRepo>
<jenkins.version>2.387.3</jenkins.version>
<spotbugs.effort>Max</spotbugs.effort>
<!-- TODO: Remove when plugin pom is using this version or newer -->
<!-- https://github.com/jenkinsci/plugin-pom/pull/869 -->
<spotbugs-maven-plugin.version>4.8.2.0</spotbugs-maven-plugin.version>
<spotbugs.threshold>Low</spotbugs.threshold>
<surefire.useFile>false</surefire.useFile>
<useBeta>true</useBeta>
Expand Down
9 changes: 8 additions & 1 deletion src/spotbugs/excludesFilter.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,15 @@
<FindBugsFilter>
<!--
Exclusions in this section have been triaged and determined to be
false positives.
false positives or not relevant for this plugin.
-->
<Match>
<Bug pattern="CT_CONSTRUCTOR_THROW" />
<Or>
<Class name="org.jenkinsci.plugins.cloudstats.CloudStatistics" />
<Class name="org.jenkinsci.plugins.cloudstats.CyclicThreadSafeCollection" />
</Or>
</Match>
<Match>
<Bug pattern="SE_NO_SERIALVERSIONID" />
<Or>
Expand Down

0 comments on commit eb5b402

Please sign in to comment.