Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purge LinkedLogRotator #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Purge LinkedLogRotator #47

wants to merge 1 commit into from

Conversation

orgads
Copy link
Contributor

@orgads orgads commented May 1, 2017

It is O(n^2), and looks like it adds no real value. The normal rotator should delete all the builds.

This might be the cause for JENKINS-38334

@olivergondza
Copy link
Member

olivergondza commented May 2, 2017 •
edited
Loading

I am trying to understand what an impact fo such a change would be.

  • The LinkedLogRotator does not ever seem to get serialized (grepped my backups). Good.
  • Presumably it was introduced before MatrixBuild#delete was refactored to delete its configuration builds so it might be unnecessary these days. Good.
  • BUT, the LinkedLogRotator is deleting inactive configurations - is this taken care of as well?

@orgads
Purge LinkedLogRotator
d1a2eec 
It is O(n^2), and looks like it adds no real value. The normal
rotator should delete all the builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orgads @olivergondza