-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JENKINS-73941 - ForceSandbox - Unify logic in Script-Security for reducing techDebt #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plugin - remove unused dependencies
…plugin - remove unused dependencies
5 tasks
jglick
reviewed
Oct 31, 2024
src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java
Show resolved
Hide resolved
jglick
approved these changes
Oct 31, 2024
jglick
reviewed
Oct 31, 2024
src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java
Outdated
Show resolved
Hide resolved
jglick
reviewed
Oct 31, 2024
src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java
Outdated
Show resolved
Hide resolved
jglick
reviewed
Oct 31, 2024
src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java
Outdated
Show resolved
Hide resolved
jglick
reviewed
Oct 31, 2024
src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java
Outdated
Show resolved
Hide resolved
jglick
reviewed
Oct 31, 2024
src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java
Outdated
Show resolved
Hide resolved
jglick
approved these changes
Oct 31, 2024
Co-authored-by: Jesse Glick <[email protected]>
jglick
reviewed
Nov 1, 2024
src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jesse Glick <[email protected]>
jglick
reviewed
Nov 4, 2024
src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jesse Glick <[email protected]>
jglick
approved these changes
Nov 4, 2024
amuniz
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-73941 - - Option to hide "Use Groovy Sandbox" for users without Administer permission globally in the system
Complements:
#584
#585
After releasing jenkinsci/workflow-cps-plugin#948 we have realized that some logic can be unified between Script-Security and Workflow-CPS plugin.
To do so, we have created the new static methods:
This PR does not include any new functionality, but decrease the techDebt maintaining both, Script-Security and Workflow-CPS Plugin
Testing done
Created new test cases for the created methods.
Submitter checklist