Add timeout option for MX DNS record lookup

[rkitover]

Add optional second parameter opts, an object that can contain the properties timeout and checkMx. The checkMx property of the opts object overrides the checkMx function parameter. The timeout property, in ms module format, specifies the timeout for the DNS MX record lookup, the default is 10 seconds.

Add test, example and update the API documentation.

[rkitover]

@jesselpalmer can you take a look please?

[jesselpalmer]

Hi @rkitover! Thank you so much for the PR. I love the idea! I am trying to beef up the tests to ensure everything is covered. I'll update this thread when I'm done.

[rkitover]

@jesselpalmer Hi, sorry to bother you, but any luck with your tests? I need this for a PR I'm doing for another node module.

[jesselpalmer]

Hey @rkitover, you definitely aren't bothering me! I appreciate the nudge 😄 This has been on my to-do list; I just haven't gotten around to it. I'll take a look this weekend.

[rkitover]

Thank you!

[jesselpalmer]

@rkitover Ok, I created a PR for your PR 😅 :

rkitover#1

Let me know what you think!

Apologies for the delay. It's been a particularly busy last month 😊

[rkitover]

@jesselpalmer

Nice work, your node is much better than mine, I don't use it much.

I didn't know that you can assign variables in object form, that's very cool.

I would recommend strengthening your Git commit discipline.

This is my favorite general explanation of how to format Git commits:

. Every project has its own practice, so when you patch other projects you want to try to match them to some degree.

Some are very strict about having a commit for every specific change, others are fine with one or a few commits for a feature and related work.

There are a few different guidelines, find one that you like for your projects.

You also want to try to have a clean commit history, you can do this with:

git fetch --all --prune
git rebase -i origin/main

. This will open up your editor with instructions on how to edit/order your history for a branch.

Anyway this is all for future reference, it doesn't matter here.

I'd appreciate it if you can do a release, then I will rework my link-check PR.

[jesselpalmer]

@rkitover Nice! Thank you so much for the resource and the tips!

Looks like I have a test acting up, so I'll fix that and then I'll do a release.

I'll update this thread after I put out the release.

[rkitover]

Awesome, thank you!

[jesselpalmer]

@rkitover I just released 2.0.0, which included these changes!

[rkitover]

Awesome, thank you!