Fix android crash Dispose() call in PlaybackEnded event

[ndegheselle]

Allow the creation of a IAudioPlayer that will be disposed imediatly after ending.

IAudioPlayer player = _audioManager.CreatePlayer(await FileSystem.OpenAppPackageFileAsync("sound.mp3");
player.PlaybackEnded += (s, e) =>
{
    player.Dispose();
};
player.Play();

[bijington]

Thank you for this. I am wondering if this is the correct fix or whether we should move the PlaybackEnded?.Invoke(this, e); line to the end of this method?

I can't decide which is best. What do you think?

[ndegheselle]

Arguably the state in which you expect the player to be then PlaybackEnded is called is the end of the playback position so I would say it's fine like that. But after checking the other place where PlaybackEnded is called seems like it's always the opposite with a Seek(0) before PlaybackEnded?.Invoke() so it's probably better to keep it coherent.

I will check if that's work fine and update the PR if you good with this

[bijington]

That would be great! Thank you

[ndegheselle]

That would be great! Thank you

Updated

[bijington]

Thank you for this!