Backport fixes #32
Merged
Backport fixes #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drehak
pushed a commit
to drehak/lunamark
that referenced
this pull request
May 18, 2021
So far, we are missing support for captions and column alignment. There are also no examples for either the `pipeTables` Lua option or the `\markdownRendererTable` token renderer. Extended tests for parsing inlines in pipe tables are also missing as of now. Progresses jgm#32.
drehak
pushed a commit
to drehak/lunamark
that referenced
this pull request
May 18, 2021
Progresses jgm#32.
drehak
pushed a commit
to drehak/lunamark
that referenced
this pull request
May 18, 2021
In Pandoc, table captions (enabled by the `table_caption` option) can be entire paragraphs. This is a little difficult to parse, because we need to detect lines that might start a block quote, a code fence, or a heading, since we support parsing these without a preceding blank line. In the case of a code fence, we need to actually read the whole code fence to see if it is valid. Therefore, this commit implements only single-line captions. Progresses jgm#32
drehak
pushed a commit
to drehak/lunamark
that referenced
this pull request
May 18, 2021
Progresses jgm#32
drehak
pushed a commit
to drehak/lunamark
that referenced
this pull request
May 18, 2021
Progresses jgm#32
drehak
pushed a commit
to drehak/lunamark
that referenced
this pull request
May 18, 2021
Progresses jgm#32
drehak
pushed a commit
to drehak/lunamark
that referenced
this pull request
May 18, 2021
Progresses jgm#32
drehak
pushed a commit
to drehak/lunamark
that referenced
this pull request
May 18, 2021
drehak
pushed a commit
to drehak/lunamark
that referenced
this pull request
May 18, 2021
Progresses jgm#32
drehak
pushed a commit
to drehak/lunamark
that referenced
this pull request
May 18, 2021
Progresses jgm#32
drehak
pushed a commit
to drehak/lunamark
that referenced
this pull request
May 18, 2021
Progresses jgm#32
drehak
pushed a commit
to drehak/lunamark
that referenced
this pull request
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains several bugfixes backported from witiko/markdown as discussed in #31. To avoid the issues we had in #30, I unit-tested the changes.