Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move section numbering code and enable for beamer #10245

Merged
merged 7 commits into from
Oct 1, 2024
Merged

Conversation

twsh
Copy link
Sponsor Contributor

@twsh twsh commented Oct 1, 2024

This means that --number-sections will now number sections in beamer.

This should be in default.latex.
I moved the template setting code to where other beamer templates are set. This makes the section-titles and numbersections variables independent.
Move the section numbering code.
Move the section numbering code.
@twsh twsh marked this pull request as draft October 1, 2024 11:59
@twsh
Copy link
Sponsor Contributor Author

twsh commented Oct 1, 2024

I'm not sure why this fails some test. I tried to update the relevant 'writer' files.

@twsh twsh marked this pull request as ready for review October 1, 2024 12:00
@jgm
Copy link
Owner

jgm commented Oct 1, 2024

Look at the test output; it will show you what is expected (looks like a line moved to a different location).

@twsh
Copy link
Sponsor Contributor Author

twsh commented Oct 1, 2024

I fixed the test, I just need to work out how to shorten the commit message that's too long.

@jgm
Copy link
Owner

jgm commented Oct 1, 2024

Don't worry, I'll squash and edit the commit msg.

@jgm jgm merged commit f2b1de5 into jgm:main Oct 1, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants