fix: omit package.json type if commonjs (#27611)

jhipster · Oct 17, 2024 · 19e1c76 · 19e1c76
1 parent 3e226f3
commit 19e1c76
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/generators/common/__snapshots__/generator.spec.ts.snap b/generators/common/__snapshots__/generator.spec.ts.snap
@@ -123,8 +123,7 @@ This application was generated using JHipster JHIPSTER_VERSION, you can find doc
   "name": "jhipster",
   "version": "0.0.0",
   "description": "Description for JHipster",
-  "license": "UNLICENSED",
-  "type": "commonjs"
+  "license": "UNLICENSED"
 }
 ",
     "stateCleared": "modified",

diff --git a/generators/javascript/generators/bootstrap/__snapshots__/generator.spec.ts.snap b/generators/javascript/generators/bootstrap/__snapshots__/generator.spec.ts.snap
@@ -19,8 +19,7 @@ exports[`generator - javascript:bootstrap customVersion-commonjs should match fi
   "name": "dasherizedBaseName",
   "version": "0.0.0",
   "description": "projectDescription",
-  "license": "UNLICENSED",
-  "type": "commonjs"
+  "license": "UNLICENSED"
 }
 ",
     "stateCleared": "modified",
@@ -73,8 +72,7 @@ exports[`generator - javascript:bootstrap packageJsonNodeEngine(true) should mat
   "name": "dasherizedBaseName",
   "version": "0.0.0",
   "description": "projectDescription",
-  "license": "UNLICENSED",
-  "type": "commonjs"
+  "license": "UNLICENSED"
 }
 ",
     "stateCleared": "modified",

diff --git a/generators/javascript/generators/bootstrap/generator.ts b/generators/javascript/generators/bootstrap/generator.ts
@@ -77,7 +77,7 @@ export default class BootstrapGenerator extends BaseApplicationGenerator {
           description: projectDescription,
           license: 'UNLICENSED',
         });
-        if (packageJsonType) {
+        if (packageJsonType === 'module') {
           this.packageJson.merge({ type: packageJsonType });
         }
         if (packageJsonNodeEngine) {