Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue module now depends on typescript module #10840

Merged
merged 15 commits into from
Sep 15, 2024
Merged

Vue module now depends on typescript module #10840

merged 15 commits into from
Sep 15, 2024

Conversation

murdos
Copy link
Contributor

@murdos murdos commented Sep 14, 2024 •
edited
Loading

See #10421

@murdos
feat: vue-core now depends on typescript module
6edfacd
@murdos
fix: avoid duplicated type in package.json
7bfd3c6
@murdos
chore: remove now redundant dependencies and scripts in vue-core, alr…
e6d21a4 
…eady declared in typescript module
@murdos
feat(vue): patch tsconfig.json from typescript module rather than ove…
10bec12 
…rwriting it
@murdos
refactor: introduce an 'apply' method on JHipsterModuleBuilder that a…
f423b87 
…llow factorizing/splitting a block of operations on a moduleBuilder
@murdos
fix(vue): remove unused @tsconfig/recommended dependency
d146288
@murdos
chore(vue): remove full tsconfig.json assertion, not required anymore
e8ce836
@murdos
chore: move creation of .npmrc file from vue to typescript module
5c80f4d
@murdos
chore(typescript): remove 'import-x' plugin for eslint
d9e0226 
It's currently only used in typescript module, no other client module uses it.
We might reintroduce it in future, if needed.
@murdos
fix(vue): piqure should be runtime dependency, not a dev dependency
5a4ee1e
@murdos
test(cucumber): module typescript should now be applied before vue-co…
989a168 
…re module
@murdos
test(tests-ci): typescript module needs to be applied before vue-core
839cdd0
@murdos
feat(vue): patch vitest config file from typescript module rather tha…
c9ebe99 
…n overwriting it
@murdos
feat(module-builder): add a new API that allows to directly add a {Ma…
df4f8f6 
…ndatory|Optional} replacer to the replacements

This allows reusing replacers, and improves readability and maintainability of the code
@murdos murdos marked this pull request as ready for review September 15, 2024 08:22
@pascalgrimaud pascalgrimaud added the $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ label Sep 15, 2024
@pascalgrimaud pascalgrimaud added the $500 https://www.jhipster.tech/bug-bounties/ label Sep 15, 2024
renanfranca
renanfranca approved these changes Sep 15, 2024
View reviewed changes
Copy link
Contributor

@renanfranca renanfranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, @murdos ! Great work!

@murdos murdos merged commit 3500a22 into jhipster:main Sep 15, 2024
34 checks passed
@murdos murdos deleted the vue-depends-on-typescript branch September 15, 2024 14:56
@murdos murdos mentioned this pull request Sep 19, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renanfranca renanfranca renanfranca approved these changes

@qmonmert qmonmert qmonmert approved these changes

@DamnClin DamnClin DamnClin approved these changes

@pascalgrimaud pascalgrimaud Awaiting requested review from pascalgrimaud

Assignees
No one assigned
Labels
area: feature request 💡 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ generator: internal theme: typescript $500 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@murdos @renanfranca @qmonmert @DamnClin @pascalgrimaud