Skip to content
This repository has been archived by the owner on Mar 21, 2021. It is now read-only.

Map all dates from server in HTTP services #632

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Map all dates from server in HTTP services #632

wants to merge 3 commits into from

Conversation

snitin315
Copy link
Contributor

@snitin315 snitin315 commented Jun 16, 2020 •
edited
Loading

Fix #482

@CLAassistant
Copy link

CLAassistant commented Jun 16, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@snitin315 snitin315 force-pushed the feat/map-all-dates-from-server branch from 03dae07 to 56cab85 Compare June 16, 2020 13:27
@snitin315 snitin315 marked this pull request as ready for review June 16, 2020 13:45
@pascalgrimaud
Copy link
Member

Thanks for proposing this, @snitin315
But there are still a lot of failures, specially in e2e tests. Can you have a look plz ?

@snitin315 snitin315 closed this Jun 22, 2020
@snitin315 snitin315 reopened this Jun 22, 2020
@snitin315 snitin315 force-pushed the feat/map-all-dates-from-server branch 2 times, most recently from 99fc918 to d56eab2 Compare June 22, 2020 04:36
@snitin315 snitin315 force-pushed the feat/map-all-dates-from-server branch 5 times, most recently from edd365b to ebc5735 Compare June 22, 2020 06:52
@snitin315 snitin315 force-pushed the feat/map-all-dates-from-server branch from ebc5735 to bad2dab Compare June 22, 2020 06:54
@snitin315
Copy link
Contributor Author

snitin315 commented Jun 22, 2020 •
edited
Loading

@pascalgrimaud fixed 👍, not sure about Vue.js / vuejs-fulli18n-es . all tests seem to pass there.

Screenshot at 2020-06-22 13-11-52

@pascalgrimaud
Copy link
Member

Last failure is related to:

Jest: "global" coverage threshold for branches (60%) not met: 59.94%

Test Suites: 98 passed, 98 total
Tests:       454 passed, 454 total
Snapshots:   0 total
Time:        52.099 s
Ran all test suites.

Maybe add another test to check all possible condition ?

@snitin315
Copy link
Contributor Author

@pascalgrimaud thanks, all green now 💯

@pascalgrimaud
Copy link
Member

Thanks @snitin315 : give me time to review and do some manual tests :)

@pascalgrimaud
Copy link
Member

@hdurix : as you opened the original issue, do you have time to have a quick look plz ?

hdurix
hdurix reviewed Jun 29, 2020
View reviewed changes
...tors/entity-client/templates/vue/src/main/webapp/app/entities/entity-update.component.ts.ejs
@@ -186,6 +186,13 @@ export default class <%= entityAngularName %>Update extends <% if (fieldsContain
return null;
}

public mapAllDatesFromServer(dates: Date[]): string[] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it not called from anywhere?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hdurix hdurix hdurix left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map all dates from server in HTTP services
4 participants
@snitin315 @CLAassistant @pascalgrimaud @hdurix