✅ Fixed sort index issue with typesense indexing #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- all models have a "title" field, and that's the default sorting field, however this is not being indexed as such for the models, except where explicitly specified (Anime and Manga models)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #491 +/- ##
============================================
+ Coverage 56.92% 57.18% +0.26%
- Complexity 1351 1352 +1
============================================
Files 339 339
Lines 5444 5454 +10
============================================
+ Hits 3099 3119 +20
+ Misses 2345 2335 -10 ☔ View full report in Codecov by Sentry. |
pushrbx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All models have a "title" field, and that's the default sorting field, however this is not being indexed as such for the models, except where explicitly specified (Anime and Manga models)
Fixes #488
Please note that after this change all of those who are self hosting need to reindex everything in typesense via:
Plus the other models: Anime, Manga, Person, Club, Profile, GenreAnime, GenreManga