Remove most uses of stdout for debug, etc. #49. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hildred
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the wrong fix. Everything using going to standard out that I found in my testing used g_print. the right fix would be to point g_print to stderr, Ces la ve. When I was able to quickly tell that g_print was used for error messages (right before asserts) or similar I used g_debug, g_warning or g_error. Usage message for the gui was left (won't interfere with batch mode, may do the right thing when not started from a terminal), Usage message for batch was changed to fprintf stderr (this will give expected results in a pipe). everything else was changed to fprintf stderr. This last group probably should be audited one of these days.
Fixes #49.