chore: move clip models #945
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #945 +/- ##
==========================================
+ Coverage 70.73% 71.71% +0.98%
==========================================
Files 23 23
Lines 1565 1584 +19
==========================================
+ Hits 1107 1136 +29
+ Misses 458 448 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
All the torch models have been migrated and tested. The onnx models will be migrated later due to my network. |
ZiniuYu
reviewed
Jan 15, 2024
|
What's the 'codecov' problem? Do you think that needs a unit test to cover? |
|
All the onnx and torch models have been transferred to huggingface successfully by now. |
ZiniuYu
requested changes
Jan 22, 2024
selmiss
commented
Jan 23, 2024
ZiniuYu
reviewed
Jan 23, 2024
ZiniuYu
approved these changes
Jan 24, 2024
numb3r3
requested changes
Jan 24, 2024
| @@ -43,7 +43,7 @@ | |||
| setup_requires=['setuptools>=18.0', 'wheel'], | |||
| install_requires=[ | |||
| 'jina>=3.12.0', | |||
| 'docarray[common]>=0.19.0,<0.30.0', | |||
| 'docarray[common]==0.21.0', | |||
There was a problem hiding this comment.
This requirement is too strong. Could we have some flexible version bump here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.