WIP: create nomad-whisper state #746
Conversation
terraform/nomad-whisper/user-data/postinstall-runner-nomad-whisper-oracle.sh
Outdated
Show resolved
Hide resolved
| sh """#!/bin/bash | ||
| export USER_PUBLIC_KEY_PATH=~/.ssh/ssh_key.pub | ||
| export ORACLE_GIT_BRANCH=\"$RELEASE_BRANCH\" | ||
| terraform/nomad-whisper/create-nomad-whisper-configuration.sh $SSH_USERNAME""" |
There was a problem hiding this comment.
| terraform/nomad-whisper/create-nomad-whisper-configuration.sh $SSH_USERNAME""" | |
| scripts/create-or-rotate-whisper.sh $SSH_USERNAME""" |
| unset SSH_USER | ||
|
|
||
| [ -z "$POOL_TYPE" ] && export POOL_TYPE="whisper" | ||
| [ -z "$ROLE" ] && export ROLE="whisper-pool" |
There was a problem hiding this comment.
Why not just make the role whisper? This value will show up in homer, among other places.
| LOCAL_PATH=$(dirname "${BASH_SOURCE[0]}") | ||
|
|
||
| [ -z "$ROLE" ] && ROLE="nomad-pool" | ||
| [ -z "$POOL_TYPE" ] && POOL_TYPE="general" |
There was a problem hiding this comment.
this pool type should be whisper, yes? or really since we defined it above we can just remove these additions.
| [ -z "$POOL_TYPE" ] && POOL_TYPE="general" |
|
|
||
| LOCAL_PATH=$(dirname "${BASH_SOURCE[0]}") | ||
|
|
||
| [ -z "$ROLE" ] && ROLE="nomad-pool" |
There was a problem hiding this comment.
| [ -z "$ROLE" ] && ROLE="nomad-pool" |
|
|
||
| [ -z "$ROLE" ] && ROLE="nomad-pool" | ||
| [ -z "$POOL_TYPE" ] && POOL_TYPE="general" | ||
| [ -z "$NAME" ] && NAME="$ENVIRONMENT-$ORACLE_REGION-$ROLE-$POOL_TYPE" |
There was a problem hiding this comment.
This name should be unique across environment, region and type. I don't believe we need both ROLE and POOL_TYPE in here. This was copied from the nomad generalized script, so it made more sense there than here.
| [ -z "$S3_STATE_KEY" ] && S3_STATE_KEY="$ENVIRONMENT/nomad-whisper/$POOL_TYPE/terraform.tfstate" | ||
|
|
||
| [ -z "$BASE_IMAGE_TYPE" ] && BASE_IMAGE_TYPE="$NOMAD_BASE_IMAGE_TYPE" | ||
| [ -z "$BASE_IMAGE_TYPE" ] && BASE_IMAGE_TYPE="JammyBase" |
There was a problem hiding this comment.
I believe we want BASE_IMAGE_TYPE here as GPU, not JammyBase
There was a problem hiding this comment.
oh, this is just a duplicate because we already define it above. on line 10
No description provided.