Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for ktlint 1.0.0 (ktlint-maven-plugin 3.0.0). #1116

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

JonathanLennox
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #1116 (5d75da9) into master (ea5b27f) will increase coverage by 0.02%.
The diff coverage is 17.82%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1116      +/-   ##
============================================
+ Coverage     27.85%   27.87%   +0.02%     
  Complexity      473      473              
============================================
  Files           128      128              
  Lines          7775     7780       +5     
  Branches       1064     1065       +1     
============================================
+ Hits           2166     2169       +3     
- Misses         5336     5339       +3     
+ Partials        273      272       -1     
Files Coverage Δ
.../src/main/kotlin/org/jitsi/jicofo/bridge/Bridge.kt 72.89% <100.00%> (+0.51%) ⬆️
...org/jitsi/jicofo/bridge/BridgeSelectionStrategy.kt 77.27% <ø> (ø)
...src/main/kotlin/org/jitsi/jicofo/bridge/Cascade.kt 74.05% <100.00%> (ø)
.../jitsi/jicofo/bridge/SingleMeshTopologyStrategy.kt 0.00% <ø> (ø)
...g/jitsi/jicofo/bridge/TopologySelectionStrategy.kt 0.00% <ø> (ø)
...c/main/kotlin/org/jitsi/jicofo/ConferenceConfig.kt 97.05% <100.00%> (ø)
...o/src/main/kotlin/org/jitsi/jicofo/FocusManager.kt 47.82% <ø> (ø)
...rc/main/kotlin/org/jitsi/jicofo/auth/AuthConfig.kt 78.04% <100.00%> (ø)
...tlin/org/jitsi/jicofo/conference/ConferenceUtil.kt 32.25% <ø> (ø)
...rg/jitsi/jicofo/conference/SourcesToAddOrRemove.kt 55.55% <100.00%> (+5.55%) ⬆️
... and 16 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea5b27f...5d75da9. Read the comment docs.

fun XMPPConnection.tryToSendStanza(stanza: Stanza) = try {
sendStanza(stanza)
} catch (e: SmackException.NotConnectedException) {
logger.error("No connection - unable to send packet: " + stanza.toXML(), e)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it doesn't enforce string templates?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess not. I'll suggest it to them.

@JonathanLennox JonathanLennox merged commit 839b212 into jitsi:master Oct 3, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants