Skip to content

Commit

Permalink
task: further instance tracker tests
Browse files Browse the repository at this point in the history 
* task: better tests for instance tracker

* test for instance averaging

* further instance tracker tests
  • Loading branch information
@aaronkvanmeerten
aaronkvanmeerten authored Mar 1, 2024
1 parent 2d51d4b commit 2b325b8
Showing 1 changed file with 254 additions and 4 deletions.
258 changes: 254 additions & 4 deletions src/test/instance_tracker.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,14 @@ describe('InstanceTracker', () => {
};

const redisClient = {
expire: mock.fn(),
zremrangebyscore: mock.fn(() => 0),
hgetall: mock.fn(),
hset: mock.fn(),
hdel: mock.fn(),
del: mock.fn(),
scan: mock.fn(),
zrange: mock.fn(),
};

const shutdownManager = {
Expand Down Expand Up @@ -81,11 +84,212 @@ describe('InstanceTracker', () => {
};
});

describe('trackerMetricsTests', () => {
test('should return the correct summary for JVB values', async () => {
// these tests are increase frequency metrics
describe('trackerMetricHighFrequencyInventoryTests', () => {
const hfGroupDetails = {
...groupDetails,
scalingOptions: {
...groupDetails.scalingOptions,
scalePeriod: 10,
},
};

test('should segment the metrics into periods', async () => {
const metricInventory = [
{ value: 0.5, instanceId: 'i-0a1b2c3d4e5f6g7h8', timestamp: Date.now() - 350 },
{
value: 0.4,
instanceId: 'i-0a1b2c3d4e5f6g7h8',
timestamp: Date.now() - hfGroupDetails.scalingOptions.scalePeriod * 1000 - 350,
},
];

const scalePeriods = Math.max(
hfGroupDetails.scalingOptions.scaleDownPeriodsCount,
hfGroupDetails.scalingOptions.scaleUpPeriodsCount,
);
redisClient.zrange.mock.mockImplementationOnce(() => metricInventory.map(JSON.stringify));

const metricInventoryPerPeriod = await instanceTracker.getMetricInventoryPerPeriod(
context,
hfGroupDetails,
scalePeriods,
hfGroupDetails.scalingOptions.scalePeriod,
);

// metrics for the instance should be segmented into correct count of periods
assert.deepEqual(metricInventoryPerPeriod.length, scalePeriods);
});

test('should segment the metrics into periods even if gaps exist in metrics', async () => {
const metricInventory = [
{ value: 0.5, instanceId: 'i-0a1b2c3d4e5f6g7h8', timestamp: Date.now() - 350 },
{
value: 0.4,
instanceId: 'i-0a1b2c3d4e5f6g7h8',
timestamp: Date.now() - 2 * hfGroupDetails.scalingOptions.scalePeriod * 1000 - 350,
},
];
const scalePeriods = Math.max(
hfGroupDetails.scalingOptions.scaleDownPeriodsCount,
hfGroupDetails.scalingOptions.scaleUpPeriodsCount,
);
redisClient.zrange.mock.mockImplementationOnce(() => metricInventory.map(JSON.stringify));

const metricInventoryPerPeriod = await instanceTracker.getMetricInventoryPerPeriod(
context,
hfGroupDetails,
scalePeriods,
hfGroupDetails.scalingOptions.scalePeriod,
);
// metrics for the instance should be segmented into correct count of periods
assert.deepEqual(metricInventoryPerPeriod.length, scalePeriods);
});

test('should extend previous values through the metrics into periods that are missing', async () => {
const metricInventory = [
{
value: 0.4,
instanceId: 'i-0a1b2c3d4e5f6g7h8',
timestamp: Date.now() - hfGroupDetails.scalingOptions.scalePeriod * 1000 - 350,
},
];
const scalePeriods = Math.max(
hfGroupDetails.scalingOptions.scaleDownPeriodsCount,
hfGroupDetails.scalingOptions.scaleUpPeriodsCount,
);
redisClient.zrange.mock.mockImplementationOnce(() => metricInventory.map(JSON.stringify));

const metricInventoryPerPeriod = await instanceTracker.getMetricInventoryPerPeriod(
context,
hfGroupDetails.name,
scalePeriods,
hfGroupDetails.scalingOptions.scalePeriod,
);
// metrics for the instance should be segmented into correct count of periods
assert.deepEqual(metricInventoryPerPeriod.length, scalePeriods);

// all periods should include a value
metricInventoryPerPeriod.map((period) => {
assert.deepEqual(period.length, 1);
});

assert.deepEqual(
context.logger.info.mock.calls[1].arguments[0],
`Filling in for missing metric from previous period`,
);
assert.deepEqual(context.logger.info.mock.calls[1].arguments[1], {
group: groupName,
instanceId: 'i-0a1b2c3d4e5f6g7h8',
periodIdx: 0,
previousMetric: metricInventory[0],
});
});
});

// these tests are for the getMetricInventoryPerPeriod method
describe('trackerMetricInventoryTests', () => {
test('should segment the metrics into periods', async () => {
const metricInventory = [
{ value: 0.5, instanceId: 'i-0a1b2c3d4e5f6g7h8', timestamp: Date.now() - 1000 },
{
value: 0.4,
instanceId: 'i-0a1b2c3d4e5f6g7h8',
timestamp: Date.now() - groupDetails.scalingOptions.scalePeriod * 1000 - 1000,
},
];
const scalePeriods = Math.max(
groupDetails.scalingOptions.scaleDownPeriodsCount,
groupDetails.scalingOptions.scaleUpPeriodsCount,
);
redisClient.zrange.mock.mockImplementationOnce(() => metricInventory.map(JSON.stringify));
const metricInventoryPerPeriod = await instanceTracker.getMetricInventoryPerPeriod(
context,
groupDetails,
scalePeriods,
groupDetails.scalingOptions.scalePeriod,
);

// metrics for the instance should be segmented into correct count of periods
assert.deepEqual(metricInventoryPerPeriod.length, scalePeriods);
});

test('should ignore older metrics and only consider the correct number of periods', async () => {
const metricInventory = [
{ value: 0.5, instanceId: 'i-0a1b2c3d4e5f6g7h8', timestamp: Date.now() - 1000 },
{
value: 0.4,
instanceId: 'i-0a1b2c3d4e5f6g7h8',
timestamp: Date.now() - groupDetails.scalingOptions.scalePeriod * 1000 - 1000,
},
{
value: 0.4,
instanceId: 'i-0a1b2c3d4e5f6g7h8',
timestamp: Date.now() - 2 * groupDetails.scalingOptions.scalePeriod * 1000 - 1000,
},
];
const scalePeriods = Math.max(
groupDetails.scalingOptions.scaleDownPeriodsCount,
groupDetails.scalingOptions.scaleUpPeriodsCount,
);
redisClient.zrange.mock.mockImplementationOnce(() => metricInventory.map(JSON.stringify));
const metricInventoryPerPeriod = await instanceTracker.getMetricInventoryPerPeriod(
context,
groupDetails,
scalePeriods,
groupDetails.scalingOptions.scalePeriod,
);

// metrics for the instance should be segmented into correct count of periods
assert.deepEqual(metricInventoryPerPeriod.length, scalePeriods);

// the oldest metric in results should match the second-oldest metric in the inventory
assert.deepEqual(metricInventoryPerPeriod.pop().pop().timestamp, metricInventory[1].timestamp);
});

test('should include a value for each instance in each period', async () => {
const instanceId = 'i-0a1b2c3d4e5f6g7h8';
const metricInventory = [
{ value: 0.5, instanceId, timestamp: Date.now() - 1000 },
{
value: 0.4,
instanceId,
timestamp: Date.now() - groupDetails.scalingOptions.scalePeriod * 1000 - 1000,
},
];
const scalePeriods = Math.max(
groupDetails.scalingOptions.scaleDownPeriodsCount,
groupDetails.scalingOptions.scaleUpPeriodsCount,
);

redisClient.zrange.mock.mockImplementationOnce(() => metricInventory.map(JSON.stringify));
const metricInventoryPerPeriod = await instanceTracker.getMetricInventoryPerPeriod(
context,
groupDetails,
scalePeriods,
groupDetails.scalingOptions.scalePeriod,
);

// metrics for the instance should be segmented into 2 periods
assert.deepEqual(metricInventoryPerPeriod.length, scalePeriods);

// each period should have a value for the instance
assert.deepEqual(
metricInventoryPerPeriod.filter((item) => {
return item.filter((i) => i.instanceId === instanceId).length > 0;
}).length,
metricInventoryPerPeriod.length,
);
});
});

// these tests are for the getSummaryMetricPerPeriod method
describe('trackerSummaryTests', () => {
test('should return the correct summary for average values', async () => {
// two timestamps are 5 seconds ago and 61 seconds ago
const metricInventoryPerPeriod = [
[{ value: 0.5, instanceId: 'i-0a1b2c3d4e5f6g7h8' }],
[{ value: 0.4, instanceId: 'i-0a1b2c3d4e5f6g7h8' }],
[{ value: 0.5, instanceId: 'i-0a1b2c3d4e5f6g7h8', timestamp: Date.now() - 5000 }],
[{ value: 0.4, instanceId: 'i-0a1b2c3d4e5f6g7h8', timestamp: Date.now() - 61000 }],
];
const periodCount = metricInventoryPerPeriod.length;

Expand All @@ -99,5 +303,51 @@ describe('InstanceTracker', () => {
//summary should average the values
assert.deepEqual(results, [0.5, 0.4]);
});
test('should return aggregated value per instance per period', async () => {
// two timestamps are 5 seconds ago and 61 seconds ago
const metricInventoryPerPeriod = [
[
{ value: 1, instanceId: 'i-0a1b2c3d4e5f6g7h8', timestamp: Date.now() - 8000 },
{ value: 0.5, instanceId: 'i-0a1b2c3d4e5f6g7h8', timestamp: Date.now() - 5000 },
],
[{ value: 0.4, instanceId: 'i-0a1b2c3d4e5f6g7h8', timestamp: Date.now() - 61000 }],
];
const periodCount = metricInventoryPerPeriod.length;

const results = await instanceTracker.getSummaryMetricPerPeriod(
context,
groupDetails,
metricInventoryPerPeriod,
periodCount,
);

//summary should average the values
assert.deepEqual(results, [0.75, 0.4]);
});
test('should first average instance metrics then average across instances', async () => {
// two timestamps are 5 seconds ago and 61 seconds ago
const metricInventoryPerPeriod = [
[
{ value: 10, instanceId: 'i-0a1b2c3d4e5f6g7h8', timestamp: Date.now() - 8000 },
{ value: 5, instanceId: 'i-0a1b2c3d4e5f6g7h8', timestamp: Date.now() - 5000 },
{ value: 1, instanceId: 'i-1tst9875bbb', timestamp: Date.now() - 5500 },
],
[
{ value: 5, instanceId: 'i-0a1b2c3d4e5f6g7h8', timestamp: Date.now() - 61000 },
{ value: 1, instanceId: 'i-1tst9875bbb', timestamp: Date.now() - 615000 },
],
];
const periodCount = metricInventoryPerPeriod.length;

const results = await instanceTracker.getSummaryMetricPerPeriod(
context,
groupDetails,
metricInventoryPerPeriod,
periodCount,
);

//summary should average the values of the instances first then average across instances in each period
assert.deepEqual(results, [4.25, 3]);
});
});
});

0 comments on commit 2b325b8

Please sign in to comment.