Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remote-control) Move robotjs import #335

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

horymury
Copy link
Contributor

@horymury horymury commented Apr 19, 2023

This is in order to avoid
image

on Electron apps using electron v23.0.0 and newer

@horymury horymury merged commit ad78c14 into master Apr 19, 2023
@csett86
Copy link
Member

csett86 commented Apr 19, 2023

Unfortunate that this performance optimization is no longer working.

Background for this was #214, which is still a recommended practice from the electron docs: https://www.electronjs.org/docs/latest/tutorial/performance#2-loading-and-running-code-too-soon

@horymury
Copy link
Contributor Author

Yep they changed something starting electron 23.0.0 and we would get the mentioned error unfortunately.

@csett86
Copy link
Member

csett86 commented Apr 19, 2023

The upstream issue is electron/electron#37404, this is affecting other modules apart from robotjs as well

@csett86
Copy link
Member

csett86 commented Apr 19, 2023

@horymury and just a fyi, Wayland screensharing was also completely broken (as in segfault every time when trying) with electron 22 or later, see jitsi/jitsi-meet-electron#829

@csett86 csett86 deleted the hmuresan/fix-remotecontrol branch July 16, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants